RE: [patch 3/4] ia64 mcount offset calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-05-16 at 12:17 -0700, Luck, Tony wrote:
> I'm not sure how to test it - but it looks somewhat suspect.

You could apply the first patch and this patch and see if ftrace still
works :)

> 
> The difficulty is in the way that ia64 tools report program addresses within bundles.
> 
> ia64 crams 3 41-bit instructions (and a 5-bit template) into a 16-byte "bundle".
> 
> Some tools report consecutive addresses like this:
> 
> 0x000
> 0x001
> 0x002
> 0x010
> 0x011
> 0x012
> 
> where the low nibble is the instruction number within the bundle.  Others go
> for:
> 
> 0x000
> 0x006
> 0x00c
> 0x010
> 0x016
> 0x01c
> 
> with the illusion that instructions take 6-byte, 6bytes, 4-bytes.

And I'm amazed that this wonderful architecture didn't become the
defacto for all users!


> 
> This patch does some fast and loose translation from hex (0x12) in the kernel
> to decimal (18) in the user tools ... which doesn't look like it fits with
> either of these conventions.

Could be broken. I'll leave it out of my next push.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux