On Sunday 13 February 2011, Guan Xuetao wrote: > This patch includes generic codes for memory management. > > Signed-off-by: Guan Xuetao <gxt@xxxxxxxxxxxxxxx> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > +#ifdef __io > +void __iomem *ioport_map(unsigned long port, unsigned int nr) > +{ > + /* we map PC lagcy 64K IO port to PCI IO space 0x80030000 */ > + return (void __iomem *) (unsigned long) > + io_p2v((port & 0xffff) + PKUNITY_PCILIO_BASE); > +} Interestingly, this function looks completely correct, but I don't see the definition for __io, so I suspect that the function is not actually getting used. Best make this unconditional. The code is obviously derived from the ARM version, which uses a macro called __io, but you don't need this macro because you only support one SoC platform. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html