On Wed, Jan 26, 2011 at 08:30:18PM +0100, Peter Zijlstra wrote: > On Wed, 2011-01-26 at 20:19 +0100, Sam Ravnborg wrote: > > > > /* Users of the generic TLB shootdown code must declare this storage space. */ > > DECLARE_PER_CPU(struct mmu_gather, mmu_gathers); > > > > If I understand this correct then this should read: > > > > /* > > * Users of the generic TLB shootdown > > * must define mmu_gathers like this: > > * DEFINE_PER_CPU(struct mmu_gather, mmu_gathers); > > */ > > > > The main difference is "declare" => "define". > > > > If you already updated this in you serie then please ignore this mail. > > This series rewrites mmu_gather to remove this per-cpu data :-), see > patch #10 which removes the DEFINE_PER_CPU()s after all users are dead. Thanks again. I better read the patch descriptions before asking next time. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
