On Fri, Jan 14, 2011 at 09:50:45AM -0800, Luck, Tony wrote:
> In file included from /home/aegl/generic-smp/arch/ia64/include/asm/pgtable.h:611,
> from include/linux/mm.h:41,
> from /home/aegl/generic-smp/arch/ia64/include/asm/uaccess.h:39,
> from include/linux/poll.h:14,
> from include/linux/rtc.h:117,
> from include/linux/efi.h:19,
> from /home/aegl/generic-smp/arch/ia64/include/asm/sal.h:40,
> from /home/aegl/generic-smp/arch/ia64/include/asm/mca.h:20,
> from arch/ia64/kernel/asm-offsets.c:17:
> include/asm-generic/pgtable.h: In function âpmdp_get_and_clearâ:
> include/asm-generic/pgtable.h:96: error: implicit declaration of function â__pmdâ
> include/asm-generic/pgtable.h:96: error: incompatible types in return
> make[1]: *** [arch/ia64/kernel/asm-offsets.s] Error 1
>
>
> Looks like arch/*/include/pgtable.h needs to define __pmd() but only x86
> was blessed with it.
So I fixed powerpc build and sparc but broke ia64 with this change
sorry, hard to make all archs build consistent. See the attached mails.
Would you be willing to implement __pmd for ia64 to fix this? Can you
check if this works?
Thanks a lot,
Andrea
========
Subject: fix ia64 build failure in pmdp_get_and_clear
From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
Implement __pmd macro for ia64 too.
Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
---
diff --git a/arch/ia64/include/asm/page.h b/arch/ia64/include/asm/page.h
index 41b6d31..961a16f 100644
--- a/arch/ia64/include/asm/page.h
+++ b/arch/ia64/include/asm/page.h
@@ -189,6 +189,7 @@ get_order (unsigned long size)
# define pgprot_val(x) ((x).pgprot)
# define __pte(x) ((pte_t) { (x) } )
+# define __pmd(x) ((pmd_t) { (x) } )
# define __pgprot(x) ((pgprot_t) { (x) } )
#else /* !STRICT_MM_TYPECHECKS */
--- Begin Message ---
- To: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
- Subject: [PATCH -mm] fix powerpc/sparc build
- From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
- Date: Mon, 10 Jan 2011 19:04:25 +0100
- Cc: akpm@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
- In-reply-to: <20110108104208.ca085298.sfr@xxxxxxxxxxxxxxxx>
This would become thp-add-pmd-mangling-generic-functions-fix-pgtableh-build-for-um-2.patch ===== Subject: thp: build fix for pmdp_get_and_clear From: Andrea Arcangeli <aarcange@xxxxxxxxxx> __pmd should return a valid pmd_t for every arch. Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx> --- diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h --- a/include/asm-generic/pgtable.h +++ b/include/asm-generic/pgtable.h @@ -93,7 +93,7 @@ static inline pmd_t pmdp_get_and_clear(s pmd_t *pmdp) { BUG(); - return (pmd_t){ 0 }; + return __pmd(0); } #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ #endif
--- End Message ---
--- Begin Message ---
- To: akpm@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: mmotm 2011-01-06-15-41 uploaded
- From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
- Date: Sat, 8 Jan 2011 10:42:08 +1100
- Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Andrea Arcangeli <aarcange@xxxxxxxxxx>
- In-reply-to: <201101070014.p070Egpo023959@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Hi Andrew, On Thu, 06 Jan 2011 15:41:14 -0800 akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to > > http://userweb.kernel.org/~akpm/mmotm/ Build results here: http://kisskb.ellerman.id.au/kisskb/head/3605/ Notably: powerpc pmac32_defconfig: In file included from arch/powerpc/include/asm/pgtable.h:200, from include/linux/mm.h:41, from include/linux/mman.h:14, from arch/powerpc/kernel/asm-offsets.c:22: include/asm-generic/pgtable.h: In function 'pmdp_get_and_clear': include/asm-generic/pgtable.h:96: warning: missing braces around initializer include/asm-generic/pgtable.h:96: warning: (near initialization for '(anonymous).pud') sparc defconfig: In file included from arch/sparc/include/asm/pgtable_32.h:456, from arch/sparc/include/asm/pgtable.h:7, from include/linux/mm.h:42, from arch/sparc/kernel/sys_sparc_32.c:12: include/asm-generic/pgtable.h: In function 'pmdp_get_and_clear': include/asm-generic/pgtable.h:96: error: missing braces around initializer include/asm-generic/pgtable.h:96: error: (near initialization for '(anonymous).pmdv') Probably a side effect of thp-add-pmd-mangling-generic-functions-fix-pgtableh-build-for-um.patch. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/Attachment: pgpyUY4fc47Er.pgp
Description: PGP signature
--- End Message ---
