> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@xxxxxxxx] > Sent: Friday, January 07, 2011 7:56 AM > To: Guan Xuetao > Cc: linux-arch@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCHv1 02/12] unicore32 core architecture: generic headers stuff > > On Saturday 25 December 2010, Guan Xuetao wrote: > > diff --git a/arch/unicore32/include/asm/sizes.h b/arch/unicore32/include/asm/sizes.h > > new file mode 100644 > > index 0000000..3720307 > > --- /dev/null > > +++ b/arch/unicore32/include/asm/sizes.h > > @@ -0,0 +1,47 @@ > > +/* > > + * linux/arch/unicore32/include/asm/sizes.h > > + * > > + * Code specific to PKUnity SoC and UniCore ISA > > + * > > + * Copyright (C) 2001-2010 GUAN Xue-tao > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > +#ifndef __UNICORE_SIZES_H__ > > +#define __UNICORE_SIZES_H__ > > + > > +/* handy sizes */ > > +#define SZ_16 0x00000010 > > +#define SZ_256 0x00000100 > > +#define SZ_512 0x00000200 > > ... > > This would be nice to have in include/asm-generic. Please make a patch that > adds the file there and use it with your scripts. Ok, my pleasure. > > > --- /dev/null > > +++ b/arch/unicore32/include/asm/stat.h > > @@ -0,0 +1,71 @@ > > +/* > > + * linux/arch/unicore32/include/asm/stat.h > > I think we discussed this particular header before. There should be no reason > to have your own version instead of using the generic file like you do for the > rest of the API headers. The generic-version stat.h can't work for existing binary file systems in unicore32. I will submit a patch for generic-version stat.h for discussion. > > Arnd Thanks arnd. Guan Xuetao -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
