On Tue, Aug 17, 2010 at 03:07:37PM +0100, David Howells wrote: > Make do_execve() take a const filename pointer so that kernel_execve() compiles > correctly on ARM: > > arch/arm/kernel/sys_arm.c:88: warning: passing argument 1 of 'do_execve' discards qualifiers from pointer target type > > This also requires the argv and envp arguments to be consted twice, once for > the pointer array and once for the strings the array points to. This is > because do_execve() passes a pointer to the filename (now const) to > copy_strings_kernel(). A simpler alternative would be to cast the filename > pointer in do_execve() when it's passed to copy_strings_kernel(). > > do_execve() may not change any of the strings it is passed as part of the argv > or envp lists as they are some of them in .rodata, so marking these strings as > const should be fine. > > Further kernel_execve() and sys_execve() need to be changed to match. > > This has been test built on x86_64, frv, arm and mips. > > Signed-off-by: David Howells <dhowells@xxxxxxxxxx> > Tested-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> David, Thanks for sorting this. Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
