On Thu, 2010-07-22 at 11:43 -0700, Yinghai Lu wrote: > > + /* Take out region array itself at first*/ > + if (memblock.reserved.regions != memblock_reserved_init_regions) > + memblock_free(__pa(memblock.reserved.regions), sizeof(struct memblock_region) * memblock.reserved.max); > + More of that horror. Don't. Another option from what i proposed earlier is to actually have a function inside mm/memblock to free it (memblock_free_arrays()) that does nothing if memblock is to survive init. I hate exporting variables or data structures like that. Functions are semantically a lot cleaner. Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html