Re: [PATCH 03/23] lmb: Print new doubled array location info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/08/2010 11:55 AM, Bjorn Helgaas wrote:
> On Sunday, July 04, 2010 12:56:07 am Yinghai Lu wrote:
>> -		pr_info(" %s[0x%x]\t0x%016llx - 0x%016llx, 0x%llx bytes\n",
>> -		    name, i, base, base + size - 1, size);
>> +		pr_info(" %s[%#x]\t[%#016llx - %#016llx], %#llx bytes\n",
>> +		    name, i, base, base + size, size);
> 
> I know you think it's prettier to have zeroes and extra spaces like this:
> 
>   [0xe7000000 - 0xe8000000, 0x1000000 bytes]
> 
> rather than a bunch of 'F's:
> 
>   [0xe7000000-0xe7ffffff]
> 
> But for the record, I still think you're wrong and that it's better
> to be consistent even if it's slightly uglier.  The inconsistencies
> lead to confusion and off-by-one errors.

We can make them to be consistent later.

current for early mem stage, it is consistent to without -1.

later I like to see all pci resource could be consistent to without -1 too.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux