On 05/14/2010 01:13 AM, Benjamin Herrenschmidt wrote: > On Thu, 2010-05-13 at 23:28 -0700, Yinghai wrote: > >> this just line by line translation from early_res version to lmb >> changes >> >> please focus on lmb core at this point. >> > Well, the problem is that you dig into the LMB core with those functions > which means I -will- break your stuff if/when I change it, for example > to use linked lists. > > then you should don't even struct lmb, and move the definition from lmb.h to lmb.c > Besides, the code lacks comments and explanation in the changeset. So > please provide that, I'm sure Thomas and Peter also want to understand > what's going on in the x86 side of things. > > -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html