On Thu, 2010-05-13 at 23:25 -0700, Yinghai wrote: > >> +u64 __lmb_find_area(u64 ei_start, u64 ei_last, u64 start, u64 end, > >> + u64 size, u64 align); > >> +u64 lmb_find_area(u64 start, u64 end, u64 size, u64 align); > > > > See my comments about sorting out the return from that function. > > > > Also, I don't understand the need for that __ version. It looks like > > something you should keep inside x86, I don't see the need for it in > the > > generic LMB code, since it just does trivial cropping of the > arguments. > > otherwise need to export lmb_find_base() and LMB_ERROR Well, then export lmb_find_base(), and just sanitize the result codes over all LMB. That's not -that- hard, it's not like there were gazillion of users yet. I don't have time now to do that myself before monday. > yes. but need that to keep switch from early_res/nobootmem to > lmb/nobootmem smooth. > > will clean it after early_res is replaced. Then make it inline inside the x86 stuff. But really, you should cleanup that result code. It's something on my TODO list for lmb that I haven't had a chance to do yet, so please look at that or wait til next week so I do it myself. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
