On Tue, Apr 27, 2010 at 09:25:34PM +0900, FUJITA Tomonori wrote: > This patchset removes useless sync_single_range_for_cpu and > sync_single_range_for_device hooks in dma_map_ops. These hooks were > for dma_sync_single_range_* DMA API, however, the API became obsolete > (the description in DMA API docs was removed too). Architecutres > should use sync_single_for_cpu and sync_single_for_device hooks > instead (as DMA API docs say, they need to support a partial sync). If you're going to do this, then please catch all instances - compare the number of places which contain "dma_sync_single_range" with your diffstat and you'll notice you've missed a _lot_ of places. $ git grep -l '\<dma_sync_single_range' arch/arm/include/asm/dma-mapping.h arch/avr32/include/asm/dma-mapping.h arch/blackfin/include/asm/dma-mapping.h arch/cris/include/asm/dma-mapping.h arch/frv/include/asm/dma-mapping.h arch/m68k/include/asm/dma-mapping.h arch/mips/include/asm/dma-mapping.h arch/mips/mm/dma-default.c arch/mn10300/include/asm/dma-mapping.h arch/parisc/include/asm/dma-mapping.h arch/xtensa/include/asm/dma-mapping.h include/asm-generic/dma-mapping-broken.h include/asm-generic/dma-mapping-common.h include/linux/ssb/ssb.h vs. > arch/ia64/kernel/pci-swiotlb.c | 2 - > arch/powerpc/kernel/dma-swiotlb.c | 4 +- > arch/powerpc/kernel/dma.c | 12 +++++----- > arch/x86/kernel/pci-swiotlb.c | 2 - > include/asm-generic/dma-mapping-common.h | 20 +----------------- > include/linux/dma-mapping.h | 10 --------- > include/linux/swiotlb.h | 10 --------- > lib/swiotlb.c | 31 ------------------------------ > 8 files changed, 10 insertions(+), 81 deletions(-) It seems there's users of this API in linux/ssb/ssb.h. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
