From: Peter Zijlstra <peterz@xxxxxxxxxxxxx> Date: Tue, 13 Apr 2010 10:37:14 +0200 > Hmm, it also assumes %pil is never anything other than 0, > PIL_NORMAL_MAX, PIL_NMI, because if: > > (%pil & 1) && (%pil != PIL_NMI) > > then you'll end up disabling NMIs. Could something like that ever > happen? The only values we ever program into the %pil are 0, PIL_NORMAL_MAX and PIL_NMI Since PIL_NMI is the largest %pil value and all bits are set in it (0xf), it doesn't matter what PIL_NORMAL_MAX actually is. Yes this all deserves a comment, I'll add one, thanks for pointing that out. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html