On 04/12/2010 10:13 PM, Benjamin Herrenschmidt wrote: > On Mon, 2010-04-12 at 21:50 -0700, Yinghai wrote: >> On 04/12/2010 09:23 PM, Benjamin Herrenschmidt wrote: >>> On Thu, 2010-04-08 at 23:03 -0700, Yinghai Lu wrote: >>>> Generic version __lmb_find_area() is going from high to low, and for 32bit >>>> active_region for 32bit does include high pages >>>> >>>> need to replace the limit with lmb.default_alloc_limit, aka get_max_mapped() >>>> >>>> with this patch, x86 32bit could use generic version of __lmb_find_area() >>> >>> So you unconditionally add access to some lmb specific data structure to >>> generic code ? That isn't going to work very well on archs that don't >>> use lmb. >> >> the whole function >> >> #ifdef CONFIG_HAVE_LMB >> u64 __init find_memory_core_early(int nid, u64 size, u64 align, >> u64 goal, u64 limit) >> { >> int i; >> >> /* Need to go over early_node_map to find out good range for node */ >> for_each_active_range_index_in_nid(i, nid) { >> u64 addr; >> u64 ei_start, ei_last; >> >> ei_last = early_node_map[i].end_pfn; >> ei_last <<= PAGE_SHIFT; >> ei_start = early_node_map[i].start_pfn; >> ei_start <<= PAGE_SHIFT; >> addr = __lmb_find_area(ei_start, ei_last, >> goal, limit, size, align); >> >> if (addr == -1ULL) >> continue; >> >> return addr; >> } >> >> return -1ULL; >> } >> #endif >> >> need to access early_node_map[], so leave the function here. > > Hrm... find_memory_core_early() is a broken API anyways. Did you add > that ? Again, you insist on pushing all over the place that crakpot > find/reserve API instead of doing a proper allocation, and it's now > leaking with ifdef's & all into the generic code. > __alloc_memory_core_early() already include that find_memory_core_early() lines it is merged for CONFIG_NO_BOOTMEM support. I split it out, so lmb_find_area_node() could reuse those lines. YH -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html