On Fri, Feb 21, 2025 at 2:26 AM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote:
>
> On Fri, Feb 21, 2025 at 6:23 PM Xi Ruoyao <xry111@xxxxxxxxxxx> wrote:
> >
> > On Fri, 2025-02-21 at 17:47 +0800, Huacai Chen wrote:
> > > Hi, Ruoyao,
> > >
> > > On Fri, Feb 21, 2025 at 5:25 PM Xi Ruoyao <xry111@xxxxxxxxxxx> wrote:
> > > >
> > > > glibc added support for .gnu.hash in 2006 and .hash has been obsoleted
> > > > far before the first LoongArch CPU was taped. Using
> > > > --hash-style=sysv might imply unaddressed issues and confuse readers.
> > > >
> > > > In the past we really had an unaddressed issue: the vdso selftests did
> > > > not know how to process .gnu.hash. But it has been addressed by commit
> > > > e0746bde6f82 ("selftests/vDSO: support DT_GNU_HASH") now.
> > > >
> > > > Just drop the option and rely on the linker default, which is likely
> > > > "both" (AOSC) or "gnu" (Arch, Debian, Gentoo, LFS) on all LoongArch
> > > > distros.
> > > What about changing to "--hash-style=both" as most architectures do?
> >
> > IMO we are more close to ARM64 for the aspect that there are no libc
> > (glibc or musl) releases lacking GNU hash support, so I prefer the ARM64
> > way.
> >
> > Maybe this should be changed for some of other architectures (RISC-V and
> > C-SKY?) as well because I guess the only reason they used "both" was
> > "hey, without this the self tests don't work on Debian" but this is
> > resolved now. Adding a few recipients and Cc for discussion.
> OK, maybe we can change it for RISC-V/C-SKY and see what they will.
>
> Huacai
>
> >
> > --
> > Xi Ruoyao <xry111@xxxxxxxxxxx>
> > School of Aerospace Science and Technology, Xidian University
Agreed that as selftests has been fixed, --hash-style=sysv can be
removed from more arches.
arch/arm64/kernel/vdso/Makefile has already removed the option.
(
I probably should add more information to
https://maskray.me/blog/2022-08-21-glibc-and-dt-gnu-hash :)
)
