On 03/26/2010 04:42 PM, Johannes Weiner wrote: > On Fri, Mar 26, 2010 at 03:21:33PM -0700, Yinghai Lu wrote: >> From: Ian Campbell <ian.campbell@xxxxxxxxxx> >> >> This avoids an infinite loop in free_early_partial(). >> >> Add a warning to free_early_partial to catch future problems. >> >> -v5: put back start > end back into WARN_ONCE() >> -v6: use one line for warning according to linus >> -v7: more test by >> >> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx> >> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> >> Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> >> Tested-by: Joel Becker <joel.becker@xxxxxxxxxx> >> Tested-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> >> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> >> Cc: Ingo Molnar <mingo@xxxxxxx> >> --- >> kernel/early_res.c | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/kernel/early_res.c b/kernel/early_res.c >> index 3cb2c66..69bed5b 100644 >> --- a/kernel/early_res.c >> +++ b/kernel/early_res.c >> @@ -333,6 +333,12 @@ void __init free_early_partial(u64 start, u64 end) >> struct early_res *r; >> int i; >> >> + if (start == end) >> + return; >> + >> + if (WARN_ONCE(start > end, "free_early_partial: wrong range [%#llx, %#llx]\n", start, end)) >> + return; > > I think you can drop the function name, it will be in the stack dump > anyway. And that would get the line back into bounds :) > > Other than that, > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> Thanks. is there any chance that dump stack only print out address instead of function name ? BTW, kernel/early_res.c will be replaced by lmb.c Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
