On Fri, 26 Mar 2010, David Daney wrote: > On 03/26/2010 02:04 PM, Linus Torvalds wrote: > > > > > > On Fri, 26 Mar 2010, David Daney wrote: > > > > > > The GCC built-in __builtin_prefetch() is a vargs function. If we > > > don't wrap the macro parameter in parentheses, a comma operator in the > > > actual argument list might cause unintended parameters to be passed to > > > __builtin_prefetch(). > > > > This seems totally pointless and actively wrong. > > Pointless, perhaps. But 'actively wrong'? Are you sure about that? Yes, I'm sure about that. Your commit message was actively misleading, and the end result is worse than the original and shows a lack of understanding of the C preprocessor. IOW, very much "actively wrong". Linus -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
