On Wed, Mar 10, 2010 at 01:24:26PM -0800, Yinghai Lu wrote: > move it to kernel/fw_memmap.c from arch/x86/kernel/e820.c > > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> > > --- > arch/x86/include/asm/e820.h | 130 ----- > arch/x86/kernel/e820.c | 1142 -------------------------------------------- > include/linux/bootmem.h | 2 > include/linux/fw_memmap.h | 114 ++++ > kernel/Makefile | 2 > kernel/fw_memmap.c | 1134 +++++++++++++++++++++++++++++++++++++++++++ Yuck. So you think we should use > 1100 lines of fw_memmap.c code instead of the 541 lines of lib/lmb.c? Why exactly would that be better? Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html