On Fri, Feb 26, 2010 at 10:12:27AM +0100, Alain Knaff wrote:
> Yes, that should be fine. So it would be static in full kernel context
> (initrd decompression) but global in preboot. As long as it doesn't clash
> with other variables of the same name, but I think that's rather unlikely
> in the "small" preboot environment.
Here's a patch to this end. I decided to change the name of the
define to something more sensible.
Are we happy with this? Shall I queue it for merging? I'd be nice
to get this into -stable as well as some other fixes for this feature.
Subject: Fix new decompressor for PIC
The ARM kernel decompressor wants to be able to relocate r/w data
independently from the rest of the image, and we do this by ensuring
that r/w data has global visibility. Define STATIC_RW_DATA to be
empty to achieve this.
Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
--
include/linux/decompress/mm.h | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/include/linux/decompress/mm.h b/include/linux/decompress/mm.h
index 5032b9a..278e6c8 100644
--- a/include/linux/decompress/mm.h
+++ b/include/linux/decompress/mm.h
@@ -14,11 +14,21 @@
/* Code active when included from pre-boot environment: */
+/*
+ * Some architectures want to ensure there is no local data in their
+ * pre-boot environment, so that data can arbitarily relocated (via
+ * GOT references). This is achieved by defining STATIC_RW_DATA to
+ * be null.
+ */
+#ifndef STATIC_RW_DATA
+#define STATIC_RW_DATA static
+#endif
+
/* A trivial malloc implementation, adapted from
* malloc by Hannu Savolainen 1993 and Matthias Urlichs 1994
*/
-static unsigned long malloc_ptr;
-static int malloc_count;
+STATIC_RW_DATA unsigned long malloc_ptr;
+STATIC_RW_DATA int malloc_count;
static void *malloc(int size)
{
--
Russell King
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
