On Mon, 2010-02-08 at 18:02 +0000, Catalin Marinas wrote: > If we do cache flushing in kunmap() we wouldn't need an additional cache > flushing for highmem pages, so you can implement pio_kunmap() > accordingly. James' point in a previous e-mail was that he doesn't want > drivers to have "if (!PageHighMem(page))". > > Now, the ARM kunmap() function doesn't seem to do any flushing, only > kunmap_atomic(). Do I miss anything? > > Also, for PIPT caches we don't actually create any D-cache aliases with > kmap, so I'm not sure why we need to always flush the cache in kunmap(). Right ... this is why the implementation is arch specific. The PIPT implementation would be a nop for lowmem and directly equivalent to the corresponding kmap for highmem (no flushes ... unless there are platform semantics requiring them because of the mappings that are in the kmaps anyway). James -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
