Hi, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> writes: > @@ -74,7 +76,10 @@ EXPORT_SYMBOL(kmap_atomic); > void kunmap_atomic(void *kvaddr, enum km_type type) > { > unsigned long vaddr = (unsigned long) kvaddr & PAGE_MASK; > - unsigned int idx = type + KM_TYPE_NR * smp_processor_id(); > + unsigned int idx; > + > + type = kmap_atomic_idx_pop(); > + idx = type + KM_TYPE_NR * smp_processor_id(); Maybe you can avoid the 4/4 patch and preserve clean bisects by renaming the unused parameter here and elsewhere, and introduce the 'type' local in this patch. void kunmap_atomic(void *kvaddr, enum km_type unused) { ... unsigned int idx, type; ... } That way, patch 3/4 will remove a genuinely unused parameter, and thus remain compile-able. - Hari -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html