Roland McGrath <roland@xxxxxxxxxx> 写于 2009-07-10 05:03:56:
> > > + ret = user_regset_copyout(&pos, &count, &kbuf, &ubuf,
> > > + regs->regs,
> > > + offsetof(struct pt_regs, regs),
> > > + end_pos);
>
> This looks odd to me. The last two arguments here are offsets into
> the userland ABI format defined by the user_regset layout. Unless
> offsetof(struct pt_regs, regs) is zero, then you need to precede
> this call with one that fills in the initial stretch of the userland
> format layout from its 0 up to offsetof(struct pt_regs, regs). If
> in fact offsetof(struct pt_regs, regs) is zero, then it would be far
> less confusing to just write 0 there IMHO. Using offsetof on
> pt_regs at all here is very confusing to me unless pt_regs describes
> the userland ABI layout (in which case the use here still doesn't
> make sense).
Thanks Roland,
Maybe I misunderstand the arguments meaning of
user_regset_copy(in/out), I rewrite these code,
use userland ABI format the same as score's pt_regs,
just like sh arch do, maybe it's easy to understand.
It will be sent out latter.
Best Regards
Liqin
?韬{.n?????%??檩??w?{.n???{饼??Ф?塄}?财??j:+v?? ? ???2??璀??摺?囤??z夸z罐?+?????w棹f
