On Sat, 4 Jul 2009, Benjamin Herrenschmidt wrote: > > BTW. I'd like to extend these if there's no objection one of these days > to also pass whether it was an exec fault, and pass the full flags to > ptep_set_access_flags(). Sure. No problem, and sounds sane. Just a tiny word of warning: right now, the conversion I did pretty much depended on the fact that even if I missed a spot, it wouldn't actually make any difference. If somebody used "flags" as a binary value (ie like the old "write_access" kind of semantics), things would still all work, because it was still a "zero-vs-nonzero" issue wrt writes. And there were cases in the hugepage handling that I had missed, that Hugh picked up. Maybe he picked them all - but be careful. I didn't add any flags (like the FAULT_FLAG_RETRY thing that started it all) that would actually _require_ everybody to always treat it as a bitmask. And some places still pass the flags down as basically just the "write or not" thing. ptep_set_access_flags() stands out as one of them (and I think your suggestion would actually clean things up), but there are probably others. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
