On Wed, 2009-05-20 at 15:06 -0700, Jeremy Fitzhardinge wrote: > Dave Hansen wrote: > > The steps are as follows, and should be bisectable: > > 1. Break out all the functions into a new asm/ptemap.h and > > include it in place of the original functions. > > 2. Move linux/mm.h arch-independent pte mapping code to > > linux/ptemap.h, include asm/ptemap.h there > > 3. Include linux/ptemap.h directly at all use sites > > (only 39 of these kernel-wide) > > 4. Standardize all the implementations to use > > pte_offset_kernel() as the basis for pte_offset_map() > > whenever possible. > > 5. Create asm-generic/ptemap.h and consolidate all the > > architectures that share the pte_offset_kernel() > > implementations. > > 6. Consolidate the three HIGHPTE implementations (x86, > > frv, ppc64) in asm-generic/ptemap.h. > > 7. Remove the direct asm/ptemap.h includes. > > This is a nice cleanup. Did you consider going an extra step and > converting all the macros into #defines? Yup. I actually have a patch doing this sitting around that just needs a bit of cleanup. I'll certainly submit it if these get in. -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
