On Wed, 8 Apr 2009 15:21:00 +0800 liqin.chen@xxxxxxxxxxxxx wrote: > From: Chen Liqin <liqin.chen@xxxxxxxxxxxxx> > > asm/asm.h, asm/atomic.h, asm/auxvec.h, asm/bitops.h, asm/bug.h, > asm/bugs.h, asm/byteorder.h, asm/cacheflush.h, asm/cache.h > and asm/checksum.h for the score architecture. > > > ... > > +#define PG_dcache_dirty PG_arch_1 > + > +#define Page_dcache_dirty(page) \ > + test_bit(PG_dcache_dirty, &(page)->flags) > +#define SetPageDcacheDirty(page) \ > + set_bit(PG_dcache_dirty, &(page)->flags) > +#define ClearPageDcacheDirty(page) \ > + clear_bit(PG_dcache_dirty, &(page)->flags) We have ugly macros in include/linux/page-flags.h which expand a page flag out into its accessors, with standardised naming: TESTSCFLAG, CLEARPAGEFLAG_NOOP, etc. It would be best of those were reused here. > > ... > -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html