* Ingo Molnar <mingo@xxxxxxx> wrote:
> I have noticed one relatively big (but easily fixable) commit
> structure problem in this tree.
>
> All of the commits have these tags:
>
> Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@xxxxxxxxxx>
> Acked-by: John Linn <john.linn@xxxxxxxxxx>
> Acked-by: John Williams<john.williams@xxxxxxxxxxxxx>
I forgot to mention that in any case _your_ signoff as the submitter
of this tree should be in all commits as well.
So for example this (sample) chain would be fine:
Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@xxxxxxxxxx>
Acked-by: John Linn <john.linn@xxxxxxxxxx>
Acked-by: John Williams<john.williams@xxxxxxxxxxxxx>
Signed-off-by: Michal Simek <monstr@xxxxxxxxx>
It's not enough to be listed as the author in the commit. (In any
case please see Documentation/SubmittingPatches and the DCO 1.1.)
Also, a minor stylistic detail, please fix this:
John Williams<john.williams@xxxxxxxxxxxxx>
to:
John Williams <john.williams@xxxxxxxxxxxxx>
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
