On Tue, 27 Jan 2009, Andrew Morton wrote: > On Sun, 25 Jan 2009 22:35:37 +0100 > Andrea Righi <righi.andrea@xxxxxxxxx> wrote: > > > diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h > > index a7cdc48..b132d69 100644 > > --- a/include/asm-generic/pgtable-nopmd.h > > +++ b/include/asm-generic/pgtable-nopmd.h > > @@ -4,6 +4,7 @@ > > #ifndef __ASSEMBLY__ > > > > #include <asm-generic/pgtable-nopud.h> > > +#include <asm/bug.h> > > > > struct mm_struct; > > > > Why not include the preferred <linux/bug.h>? > > > BTW, I only tested this on x86 and x86_64. This needs more testing because it > > touches also a lot of other architectures. > > Hopefully Geert, Roman, David and Hirokazu Takata will have time to > help out here. atari_defconfig builds fine and boots on ARAnyM. sun3_defconfig fails with: | CC mm/memory.o | mm/memory.c: In function 'free_pmd_range': | mm/memory.c:176: error: implicit declaration of function '__pmd_free_tlb' | mm/memory.c: In function '__pmd_alloc': | mm/memory.c:2903: error: implicit declaration of function 'pmd_alloc_one_bug' | mm/memory.c:2903: warning: initialization makes pointer from integer without a cast | mm/memory.c:2917: error: implicit declaration of function 'pmd_free' | make[3]: *** [mm/memory.o] Error 1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html