On Thu, Dec 11, 2008 at 02:04:25PM +0100, Arnd Bergmann wrote:
> On Thursday 11 December 2008, Kyle McMartin wrote:
> > - */
> > -union thread_union init_thread_union
> > - __attribute__((__section__(".data.init_task"),
> > - __aligned__(THREAD_SIZE))) =
> > - { INIT_THREAD_INFO(init_task) };
> > -
>
> The __aligned__(THREAD_SIZE) is only present in sparc, mips and
> parisc (though the latter uses 128 byte align). I guess you
> verified that dropping it is ok for parisc, but is that also
> true for mips and sparc?
Duhh... Good point. The alignment is also enforced or at least should
be enforced in vmlinux.lds.S. Which in case of MIPS
[...]
. = ALIGN(_PAGE_SIZE);
*(.data.init_task)
[...]
only enforces _PAGE_SIZE alignment and _PAGE_SIZE can be less than
THREAD_SIZE so removing the __aligned__ would have broken things. Of
course that's a bug of the linker script not Kyle's patches.
Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
