On Sat, 29 Nov 2008 10:38:58 +0100 Ingo Molnar <mingo@xxxxxxx> wrote: > > * Hitoshi Mitake <h.mitake@xxxxxxxxx> wrote: > > > +#define readq readq > > +#define writeq writeq > > hm, that's done to override the generic definition? Looks weird and i > think that's rather fragile - it's easy to somehow get the generic header > without this override. No, the purpose of this #define is to let user of this function to know there's readq/writeq. Like this, #ifdef readq /* do something */ #endif But this is old way. ARCH_HAS_READQ and ARCH_HAS_WRITEQ are new ways to determine existence of readq/writeq. Drivers which use readq/writeq should depend on these values in their Kconfig file. This definitions may be redundant. But there are some architectures which already have this definition for same purpose. So I added. Should I remove these? -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
