On Wed, 2 Jul 2008 23:06:36 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > This breaks on sparc64. > > > + err = smp_call_function_single(i, > > + > > __relay_set_buf_dentry, > > + &disp, 0, > > 1); > > Because that ain't implemented. > > There's a call in net/iucv/iucv.c, but that's s390-only. > > There's a call in virt/kvm/kvm_main.c. > > There's a call in kernel/time/tick-broadcast.c, so I assume that the > intersection between CONFIG_GENERIC_CLOCKEVENTS_BROADCAST and > non-smp_call_function_single() architectures is presently empty. Hi, I'm not sure what I should do. Maybe disable relay_late_setup_files() on sparc64, with an empty inline? > I guess all SMP-capable architectures should now implement this, > please. It is presently defined on all architectures for CONFIG_SMP=n > and it is declared in include/linux/smp.h. sparc64 seems to have smp_call_function_mask(). If we have the generic kernel/smp.c in linux-next or -mmotm, then this will define smp_call_function_single() to call smp_call_function_mask(). Is there anything I can do regarding this patch? Does it work since kernel/smp.c reappeared? Eduard -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
