On Thursday 26 June 2008, monstr@xxxxxxxxx wrote: > include/asm-generic/sockios.h | 23 +++++++++++++++++++++++ > include/asm-generic/ucontext.h | 24 ++++++++++++++++++++++++ > include/asm-microblaze/fcntl.h | 1 + > include/asm-microblaze/sockios.h | 23 +++++++++++++++++++++++ > include/asm-microblaze/ucontext.h | 1 + The grouping of files seems rather arbitrary here. What would be really good here is if you had all the new asm-generic files as separate patches, i.e. as a series adding them independent of the microblaze patches so that the other arch maintainers could look at them and start using the same files, and then add all your trivial wrappers in a single patch. Also, the sockios file here looks like it should be in asm-generic. The contents of the files in this patch all look good, they are identical to the majority of the other architectures. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
