On Thu, May 29, 2008 at 12:56:02PM -0700, Harvey Harrison wrote:
> diff --git a/include/asm-arm/byteorder.h b/include/asm-arm/byteorder.h
> index e6f7fcd..d88a5ce 100644
> --- a/include/asm-arm/byteorder.h
> +++ b/include/asm-arm/byteorder.h
> @@ -18,7 +18,15 @@
> #include <linux/compiler.h>
> #include <asm/types.h>
>
> -static inline __attribute_const__ __u32 ___arch__swab32(__u32 x)
> +#ifdef __ARMEB__
> +# define __BIG_ENDIAN
> +#else
> +# define __LITTLE_ENDIAN
> +#endif
> +
> +#define __SWAB_64_THRU_32__
> +
> +static inline __attribute_const__ __u32 __arch_swab32(__u32 x)
> {
> __u32 t;
>
> @@ -40,19 +48,8 @@ static inline __attribute_const__ __u32 ___arch__swab32(__u32 x)
>
> return x;
> }
> +#define HAVE_ARCH_SWAB32
>
> -#define __arch__swab32(x) ___arch__swab32(x)
> -
> -#if !defined(__STRICT_ANSI__) || defined(__KERNEL__)
> -# define __BYTEORDER_HAS_U64__
> -# define __SWAB_64_THRU_32__
> -#endif
> -
> -#ifdef __ARMEB__
> -#include <linux/byteorder/big_endian.h>
> -#else
> -#include <linux/byteorder/little_endian.h>
> -#endif
> +#include <linux/byteorder.h>
>
> #endif
> -
On the face of it, looks fine. However, I noticed that in your reply to
patch 3 you said you'll resend stuff - is there any point in me looking
at the remainder of this patch set?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
