Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote: > -#ifdef __CHECKER__ > -extern unsigned long __builtin_bswap_32(unsigned long x); > -extern unsigned short __builtin_bswap_16(unsigned short x); > -#endif Why did you remove this? Sparse tends to complain a lot when we're calling builtins it doesn't know about... > -/* > - * avr32-linux-gcc versions earlier than 4.2 improperly sign-extends > - * the result. > - */ > -#if !(__GNUC__ == 4 && __GNUC_MINOR__ < 2) I'd also prefer not reintroducing subtle code generation bugs deep in the ext2 filesystem... It could be that using inlines instead of macros may cover up this bug, but I wouldn't count on it. So please make sure that we fall back to the default, non-optimized implementation for gcc versions earlier than 4.2. Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
