Hi Arnd, I am not discouraged from negative comments. I got school from Wolfgang Denk on U-BOOT project. (Thanks Wolfgang :-)) I only want to direct this to right way. That's all. And positive ACK to some files give me better view what's wrong. :-) Have a good day, Michal >> I saw a lot of comments about files but I have never seen any comments that >> any file is OK. >> Does it mean everything is broken??? I don't think so. > > I've commented mostly on the header files defining the ABI. Since my aim > is to have the ABI definition entirely in asm-generic/*.h, every exported > file that has more than one line in it should be changed. > > The files that implement the architecture support itself all look good > to me, but since I'm not familiar with the architecture, I'm not trying > to comment on them. > > I think you're doing a great job on this. Any patch set of this size that > has been maintained for a long time outside of the kernel goes through this > phase where everyone tells you what to improve, based on their experience, > while everything you do right about the patches is just taken for granted. > > Don't let yourself get discouraged by the negative comments, we're really > all just trying to help you do the right thing! > >> I'll integrate reported bugs and send microblaze_v3 version. > > Ok, thanks! > > Arnd <>< > > -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html