On Saturday 03 May 2008, monstr@xxxxxxxxx wrote: > > #include <asm/errno.h> > + > +#ifdef CONFIG_PPC_PSERIES > #include <asm/dcr.h> > +#endif > The patch looks basically good, but we normally try to not have an #include inside of #ifdef. If the file builds without this #include, maybe you should better leave it out entirely? Same for the ppc-pci.h in the other file. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
