Re: [PATCH] Change long to unsigned long in ptrace functions to fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Paul Mackerras <paulus@xxxxxxxxx>
Date: Fri, 2 May 2008 09:10:27 +1000

> Sparse warns every time we have an (unsigned long __user *) cast on a
> long (not unsigned long) variable.  This happens frequently in the
> ptrace code because the addr and data arguments to sys_ptrace,
> ptrace_request, arch_ptrace et al. are long rather than unsigned long.
> 
> There doesn't seem to be any good reason not to have them be unsigned,
> so this changes them from long to unsigned long.
> 
> Signed-off-by: Paul Mackerras <paulus@xxxxxxxxx>

Thanks for fixing this:

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

I thought there might be some cases that cared about
negative values of 'addr', but I can't see any.
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux