On Tue, Apr 22 2008, Paul Mackerras wrote: > Jens Axboe writes: > > > I touched on both of these points in the initial mail, but perhaps you > > missed it as I didn't CC everyone for the 0/11 part. I'll add the full > > explanation to the 1/11 patch as well. > > OK, that would be fine. I didn't read right to the end of the 0/11 > mail in detail, I admit. :) I don't blame you :-) > Now that I have, I don't see anything about smp_send_stop trying to > get the interrupt sent off in a panic situation when some other cpu > might be stuck holding the lock (unless that's the "ipi_lock is a > little muddy" part, but that only talks about cpu onlining). That bit > looks to be powerpc-specific, added in commit e057d985 in December > 2007, so perhaps a mention that that has gone away now in the > description for 3/11 would be good. Oh that, yes I'll add a description. I didn't really think there was much need for it anymore, but it should at least be documented. The ipi_lock stuff was really more about stopping IPIs completely, not the smp_send_stop() panic() you described. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html