On Thu, 2008-04-17 at 09:18 -0700, Linus Torvalds wrote:
>
> On Thu, 17 Apr 2008, Peter Zijlstra wrote:
> >
> > Jeremy, did I get the paravirt stuff right?
Still wanting to know if I got it right.
> I don't think this is worth it to virtualize.
>
> We access the page tables directly in any number of places, having a
> "get_pte()" indirection here is not going to help anything.
>
> Just make it an x86-only inline function. In fact, you can keep it inside
> arch/x86/mm/gup.c, because nobody else is likely to ever even need it,
> since normal accesses are all supposed to be done under the page table
> spinlock, so they do not have this issue at all.
>
> The indirection and virtualization thing is just going to complicate
> matters for no good reason.
Here you go ;-)
Index: linux-2.6/arch/x86/mm/gup.c
===================================================================
--- linux-2.6.orig/arch/x86/mm/gup.c
+++ linux-2.6/arch/x86/mm/gup.c
@@ -9,6 +9,49 @@
#include <linux/vmstat.h>
#include <asm/pgtable.h>
+#ifdef CONFIG_X86_PAE
+
+/*
+ * Companion to native_set_pte_present(); normal access takes the pte_lock
+ * and thus doesn't need it.
+ *
+ * This closes the race:
+ *
+ * CPU#1 CPU#2
+ * ===== =====
+ *
+ * fast_gup:
+ * - read low word
+ *
+ * native_set_pte_present:
+ * - set low word to 0
+ * - set high word to new value
+ *
+ * - read high word
+ *
+ * - set low word to new value
+ *
+ */
+static inline pte_t native_get_pte(pte_t *ptep)
+{
+ pte_t pte;
+
+retry:
+ pte.pte_low = ptep->pte_low;
+ smp_rmb();
+ pte.pte_high = ptep->pte_high;
+ smp_rmb();
+ if (unlikely(pte.pte_low != ptep->pte_low))
+ goto retry;
+ return pte;
+}
+
+#else
+
+#define native_get_pte(ptep) (*(ptep))
+
+#endif
+
/*
* The performance critical leaf functions are made noinline otherwise gcc
* inlines everything into a single function which results in too much
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
