Re: [patch 06/24] kvm: provide kvm.h for all architecture: fixes headers_install

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, 28 Mar 2008, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> 
> Currently include/linux/kvm.h is not considered by make headers_install,
> because Kbuild cannot handle " unifdef-$(CONFIG_FOO) += foo.h.  This problem
> was introduced by 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e, which makes this
> an 2.6.25 regression.

That makes no sense. Commit 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e is 
"include falloc.h in header-y", and seems to have nothing to do with 
kvm.h.

I absolutely detest how people put git commit SHA1's without any other 
information anyway, but this is a classic example of why you shouldn't do 
that: if somebody had actually bothered to look at what the SHA1 was, that 
person would probably have realized that the SHA1 was wrong.

So please - add the one-liner to all SHA1 ones, so that non-git people see 
what it is all about, and so that people who just read the commit log can 
make sense of it. And in trying to make sense of it, it can become obvious 
that it doesn't actually make any sense!

Of if the addition of falloc.h really _does_ matter, can somebody explain 
it to me?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux