On Tue, Jan 22, 2008 at 09:56:57AM +0900, Paul Mundt wrote: > On Mon, Jan 21, 2008 at 01:06:41PM +0100, Sam Ravnborg wrote: > > On Mon, Jan 21, 2008 at 07:52:57PM +0900, Paul Mundt wrote: > > > On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: > > > > On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: > > > > > On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: > > > > > > Sam Ravnborg <sam@xxxxxxxxxxxx> writes: > > > > > > > > > > > > > On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: > > > > > > >> so the ## is being taken directly rather than acting as a concatenation. > > > > > > > > > > > > > > Strange... > > > > > > > I can reproduce with gcc 3.4.5 here - will fix. > > > > > > > > > > > > The ## operator does not work with -traditional. > > > > > > > > > > Crap - then it breaks at the following architectures: > > > > > sh64, s390, m68k, m32r > > > > > > > > > > Thanks Andreas. > > > > > > > > OK - I was too quick it seem. > > > > sh has: > > > > arch/sh/Makefile:CPPFLAGS_vmlinux.lds := -traditional > > > > > > > > So this needs to be ripped out as it is not needed. > > > > > > > Yes, that can be killed. If this is aimed at 2.6.25, I'll just kill it > > > off in my tree. Otherwise, feel free to roll this in to your patch set. > > > > It is aimed for 2.6.25 and it looks reasonable to reach that goal. > > So please take this patch in your tree. > > > Done. Thanks Paul, and thanks for the prompt testing! Sam - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html