On Sun, 13 Jan 2008, Nick Piggin wrote: > > OK, you have to read to the 3rd paragraph. That one doesn't actually say what the point is either. It just claims that there *is* a point that isn't actually explained or mentioned further. > Well the immediate improvement from this actual patch is just that > it gives better and smaller code for vm_normal_page (even if you > discount the debug checks in the existing code). It does no such thing, except for the slow-path that doesn't matter. So it may optimize the slow-path (PFNMAP/MIXMAP), but the real path stays exactly the same from a code generation standpoint (just checking a different bit, afaik). If those pte_special bits are required for unexplained lockless get_user_pages, is this going to get EVEN WORSE when s390 (again) cannot do it? Linus - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html