On Fri, Nov 09, 2007 at 06:40:23PM +0900, Paul Mundt wrote: > On Fri, Nov 09, 2007 at 09:26:52AM +0000, Ralf Baechle wrote: > > If writesb() is not an official API then maybe the answer should have been > > to either add that API to other architectures or fix the driver. > > > > I guess this incident means I need to go through all Kconfig* files to > > see what bogus architecture dependencies on MIPS or !MIPS exist ... > > > While writesb() isn't an official API, the iowriteX_rep() interfaces > theoretically are. Tidying up the driver for iomap is probably a better > option. writesb() predates iowriteX_rep() interfaces by quite a number of years, though if you're using writesb(), converting over to iowriteX_rep() is really a no-brainer. writesb() is effectively what mmio_outsb() is, and exists to do what outsb() does but for peripherals mapped using ioremap on ARM rather than trying to emulate them via the legacy x86 IO interfaces. Note that it would've been far better that whoever invented mmio_outsb() looked around and noticed that some of us already have an implementation called writesb()... but time has proven that folk seem to be blinkered to anything not x86. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
