Re: [PATCH net-next v2 12/12] net: homa: create Makefile and Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 25, 2024 at 8:27 PM D. Wythe <alibuda@xxxxxxxxxxxxxxxxx> wrote:
>
> On 11/12/24 7:40 AM, John Ousterhout wrote:
>
> A small formatting issue, perhaps you're using spaces?

Yep; I fixed the formatting in Kconfig based on input from Randy
Dunlap earlier in this message train.

> > +menuconfig HOMA
> > +     tristate "The Homa transport protocol"
> > +     depends on INET
> > +     depends on IPV6
>
> Can HOMA run in an environment without IPv6(IPv4 only)? If so, depends is not suitable here. Perhaps
> what you need is to implement different branches in the code using
>
> #if IS_ENABLED(CONFIG_IPV6)

No, Homa really can't run in environments without IPv6: internally,
Homa stores all addresses as IPv6 addresses, converting to/from IPv4
at the interfaces with other kernel functions. Hopefully that is not a
problem? And given that, "depends on IPV6" is OK, right?

-John-





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux