On Tue, Feb 06, 2024 at 07:06:07PM +0100, Oleg Nesterov wrote: > Or we can check task->files != NULL rather than PF_EXITING. > > To me this looks even better, but looks more confusing without a comment. > OTOH, imo this needs a comment anyway ;) I thought about this, but I didn't really understand the null check in exit_files(); if it can really be called more than once, are there other cases where task->files == NULL that we really should report EBADF? Tycho