On Wed, 25 Oct 2023 16:01:58 +0200, Miklos Szeredi wrote: > Implement mount querying syscalls agreed on at LSF/MM 2023. > > Features: > > - statx-like want/got mask > - allows returning ascii strings (fs type, root, mount point) > - returned buffer is relocatable (no pointers) > > [...] I think we should start showing clear signs of commitment to this. In absence of strong objections I don't see a reason to let this rot on list until we forget about it. Maybe this will entice people to provide more reviews as well. It's all pretty close to what we discussed at LSFMM23 and we stated that we aim to merge something by the end of the year. Let's see if that can actually happen. I don't have huge quarrels with this. Yes, there's stuff I'd like to see done differently but nothing I consider blockers. So let's get this into -next once rc1 is out so it can get a full cycle of exposure. I've renamed struct statmnt to struct statmount to align with statx() and struct statx. I also renamed struct stmt_state to struct kstatmount as that's how we usually do this. And I renamed struct __mount_arg to struct mnt_id_req and dropped the comment. Libraries can expose this in whatever form they want but we'll also have direct consumers. I'd rather have this struct be underscore free and officially sanctioned. --- Applied to the vfs.mount branch of the vfs/vfs.git tree. Patches in the vfs.mount branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.master [1/6] add unique mount ID https://git.kernel.org/vfs/vfs/c/ec873c3baa0c [2/6] mounts: keep list of mounts in an rbtree https://git.kernel.org/vfs/vfs/c/f15247ad234c [3/6] namespace: extract show_path() helper https://git.kernel.org/vfs/vfs/c/6e5f64ac5382 [4/6] add statmount(2) syscall https://git.kernel.org/vfs/vfs/c/edf3b2ac1bd5 [5/6] add listmount(2) syscall https://git.kernel.org/vfs/vfs/c/4412ca803757 [6/6] wire up syscalls for statmount/listmount https://git.kernel.org/vfs/vfs/c/d0a56e829d2c
