Re: [PATCH v2] syscalls: Cleanup references to sys_lookup_dcookie()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Arnd, is this a good candidate for 6.7? Though old, the patch applies
cleanly on 6.6-rc4. I can re-send this one if you would prefer that.

On 8/3/2023 2:44 PM, Sohil Mehta wrote:
> On 7/10/2023 11:51 AM, Sohil Mehta wrote:
>> commit 'be65de6b03aa ("fs: Remove dcookies support")' removed the
>> syscall definition for lookup_dcookie.  However, syscall tables still
>> point to the old sys_lookup_dcookie() definition. Update syscall tables
>> of all architectures to directly point to sys_ni_syscall() instead.
>> Signed-off-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>
>> Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx> # for perf
> The patch has received a couple of additional Acks.


Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Acked-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

> Does this seem like a valuable cleanup? If so, should it go through the
> asm-generic tree?

The main motivation here is to make readers aware upfront (via the
syscall table itself) that no implementation exists for lookup_dcookie
instead of them searching for one and realizing the same. The syscall
tables do something similar for _sysctl().

Please let me know if this change seems unnecessary. I can drop the
annoying pings in that case.


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux