On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > +int futex_wait(u32 __user *uaddr, unsigned int flags, u32 val, ktime_t *abs_time, u32 bitset) > +{ > + struct hrtimer_sleeper timeout, *to; > + struct restart_block *restart; > + int ret; > + > + to = futex_setup_timer(abs_time, &timeout, flags, > + current->timer_slack_ns); > + > + ret = __futex_wait(uaddr, flags, val, to, bitset); > + if (!to) > + return ret; Can you please put an empty new line and a comment between the __futex_wait() and the if (!to) check? The original code was less obfuscated. Other than that: Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>