Re: [PATCH] syscalls: Fix file path names in the header comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, Jun 16, 2023, at 20:31, Sohil Mehta wrote:
> Some of the syscall definitions have moved due to the original source
> file being moved into a sub-directory. Update the file path names to
> reflect that.
> A couple of syscalls such as lookup_dcookie() and nfsservctl() don't
> have a syscall definition anymore. Clear the filename and leave the
> original subsystem name intact for reference.
> Signed-off-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>

Thanks for going through these!

> Arguably, having filenames in comments might not be the best idea.  If the
> intention is to make it easier to find a syscall definition, it is probably
> faster to just use 'git grep SYSCALL_DEFINE | grep <syscall_name>'.  Please let
> me know if it would be preferable to just get rid of these comments all
> together.

It's probably not worth trying to keep the comments in sync, I'd be in
favor of just removing them all.


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux