On Tue, 2023-06-13 at 10:44 +0300, Mike Rapoport wrote: > > Previous patches have done the first step, so next move the callers > > that > > don't have a VMA to pte_mkwrite_novma(). Also do the same for > > I hear x86 maintainers asking to drop "previous patches" ;-) > > Maybe > This is the second step of the conversion that moves the callers ... Really? I've not heard that. Just a strong aversion to "this patch". I've got feedback to say "previous patches" and not "the last patch" so it doesn't get stale. I guess it could be "previous changes". > > > pmd_mkwrite(). This will be ok for the shadow stack feature, as > > these > > callers are on kernel memory which will not need to be made shadow > > stack, > > and the other architectures only currently support one type of > > memory > > in pte_mkwrite() > > > > Cc: linux-doc@xxxxxxxxxxxxxxx > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > Cc: linux-s390@xxxxxxxxxxxxxxx > > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx > > Cc: linux-arch@xxxxxxxxxxxxxxx > > Cc: linux-mm@xxxxxxxxx > > Signed-off-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx> > > Reviewed-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx> Thanks!