On Fri 14-04-23 21:29:03, Amir Goldstein wrote: > Report mntid in an info record of type FAN_EVENT_INFO_TYPE_MNTID > with FAN_UNMOUNT event in addition to the fid info record. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> This patch looks good to me (besides the things you've already noticed). Just one nit below. > diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c > index 0b3de6218c56..db3b79b8e901 100644 > --- a/fs/notify/fanotify/fanotify_user.c > +++ b/fs/notify/fanotify/fanotify_user.c > @@ -120,7 +120,9 @@ struct kmem_cache *fanotify_perm_event_cachep __read_mostly; > #define FANOTIFY_EVENT_ALIGN 4 > #define FANOTIFY_FID_INFO_HDR_LEN \ > (sizeof(struct fanotify_event_info_fid) + sizeof(struct file_handle)) > -#define FANOTIFY_PIDFD_INFO_HDR_LEN \ > +#define FANOTIFY_MNTID_INFO_LEN \ > + sizeof(struct fanotify_event_info_mntid) > +#define FANOTIFY_PIDFD_INFO_LEN \ I agree with changing FANOTIFY_PIDFD_INFO_HDR_LEN to FANOTIFY_PIDFD_INFO_LEN but as a separate patch please. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
