Hi Casey, I love your patch! Yet something to improve: [auto build test ERROR on kees/for-next/hardening] [also build test ERROR on pcmoore-selinux/next acme/perf/core linus/master v6.1-rc2 next-20221026] [cannot apply to tip/perf/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/LSM-Identify-modules-by-more-than-name/20221026-034541 base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening patch link: https://lore.kernel.org/r/20221025184519.13231-8-casey%40schaufler-ca.com patch subject: [PATCH v1 7/8] LSM: Create lsm_module_list system call config: arm-randconfig-r031-20221025 (attached as .config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/e4fdffbcada3e48a7f4049e4c872642a1fed8f04 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Casey-Schaufler/LSM-Identify-modules-by-more-than-name/20221026-034541 git checkout e4fdffbcada3e48a7f4049e4c872642a1fed8f04 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from security/lsm_syscalls.c:15: include/linux/syscalls.h:1060:42: warning: declaration of 'struct lsm_ctx' will not be visible outside of this function [-Wvisibility] asmlinkage long sys_lsm_self_attr(struct lsm_ctx *ctx, size_t *size, int flags); ^ security/lsm_syscalls.c:47:1: error: conflicting types for 'sys_lsm_self_attr' SYSCALL_DEFINE3(lsm_self_attr, ^ include/linux/syscalls.h:220:36: note: expanded from macro 'SYSCALL_DEFINE3' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^ include/linux/syscalls.h:229:2: note: expanded from macro 'SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^ include/linux/syscalls.h:243:18: note: expanded from macro '__SYSCALL_DEFINEx' asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^ <scratch space>:65:1: note: expanded from here sys_lsm_self_attr ^ include/linux/syscalls.h:1060:17: note: previous declaration is here asmlinkage long sys_lsm_self_attr(struct lsm_ctx *ctx, size_t *size, int flags); ^ >> security/lsm_syscalls.c:171:1: error: conflicting types for 'sys_lsm_module_list' SYSCALL_DEFINE3(lsm_module_list, ^ include/linux/syscalls.h:220:36: note: expanded from macro 'SYSCALL_DEFINE3' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^ include/linux/syscalls.h:229:2: note: expanded from macro 'SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^ include/linux/syscalls.h:243:18: note: expanded from macro '__SYSCALL_DEFINEx' asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^ <scratch space>:104:1: note: expanded from here sys_lsm_module_list ^ include/linux/syscalls.h:1061:17: note: previous declaration is here asmlinkage long sys_lsm_module_list(unsigned int *ids, size_t *size, int flags); ^ 1 warning and 2 errors generated. vim +/sys_lsm_module_list +171 security/lsm_syscalls.c 157 158 /** 159 * lsm_module_list - Return a list of the active security modules 160 * @ids: the LSM module ids 161 * @size: size of @ids, updated on return 162 * @flags: reserved for future use, must be zero 163 * 164 * Returns a list of the active LSM ids. On success this function 165 * returns the number of @ids array elements. This value may be zero 166 * if there are no LSMs active. If @size is insufficient to contain 167 * the return data -E2BIG is returned and @size is set to the minimum 168 * required size. In all other cases a negative value indicating the 169 * error is returned. 170 */ > 171 SYSCALL_DEFINE3(lsm_module_list, -- 0-DAY CI Kernel Test Service https://01.org/lkp
Attachment:
.config.gz
Description: application/gzip
